This repository was archived by the owner on Jul 19, 2025. It is now read-only.
Support authorizing asana requests via tokens #130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxjacobson
force-pushed
the
mj/asana-personal-access-token
branch
from
159a5c5 to
5fbde43
Compare
gdiggs
reviewed
Dec 16, 2016
| class CC::Service::Asana < CC::Service | ||
| class Config < CC::Service::Config | ||
| attribute :api_key, Axiom::Types::String, label: "API key" | ||
| attribute :personal_access_token, Axiom::Types::String, label: "Personal Access Token" |
Contributor
There was a problem hiding this comment.
Can we treat this like the GH tokens and only display the full thing once?
Contributor
Author
There was a problem hiding this comment.
Sure, good call. I'll open an app PR that uses this branch and adds the obfuscation there
Contributor
There was a problem hiding this comment.
Cool - wasn't sure if we needed to do something special here as well
Contributor
Author
There was a problem hiding this comment.
I thought we would need to do something special, but while testing locally it seems like everything Just Works ™️ even without changing the views in app :)
maxjacobson
changed the title
maxjacobson
force-pushed
the
mj/asana-personal-access-token
branch
2 times, most recently
from
dd881d1 to
8d1da1f
Compare
Asana is deprecating their API Key access, as reported by a helpful user. https://asana.com/developers/documentation/getting-started/auth#api-key We confirmed with their support team that they're planning to drop support for API Key authorization in "early 2017". This PR introduces support for authorizing with personal access tokens, and attempts to nudge users in that direction gently. I think we'll need to make a plan about how to migrate existing repos over.
maxjacobson
force-pushed
the
mj/asana-personal-access-token
branch
from
8d1da1f to
af83a9a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana is deprecating their API Key access, as reported by a helpful
user.
https://asana.com/developers/documentation/getting-started/auth#api-key
We confirmed with their support team that they're planning to drop
support for API Key authorization in "early 2017".
This PR introduces support for authorizing with personal access tokens,
and attempts to nudge users in that direction gently. I think we'll need
to make a plan about how to migrate existing repos over.